Open
Conversation
jo-z
reviewed
Nov 3, 2025
| import remarkGfm from 'remark-gfm'; | ||
|
|
||
| const config: StorybookConfig = { | ||
| "stories": [ |
jo-z
reviewed
Nov 3, 2025
jo-z
reviewed
Nov 3, 2025
| @@ -60,12 +62,11 @@ class SparklyText extends HTMLElement { | |||
| --_sparkle-base-size: var(--sparkly-text-size, 15px); | |||
Collaborator
There was a problem hiding this comment.
can we default this to inherit instead? And generally do font sizes in rem so they work nicely with assistive tech that increases font size?
jo-z
reviewed
Nov 3, 2025
jo-z
reviewed
Nov 3, 2025
|
|
||
| <style> | ||
| sparkly-text { | ||
| font-family: 'Nunito Sans', 'Helvetica Neue', Helvetica, Arial, sans-serif; |
Collaborator
There was a problem hiding this comment.
can this also inherit? makes it easier to use
jo-z
reviewed
Nov 3, 2025
jo-z
reviewed
Nov 4, 2025
| } | ||
| }, | ||
| args: { | ||
| children: createRawSnippet(() => ({ render: () => 'Sparkly Text' })) |
Collaborator
There was a problem hiding this comment.
Suggested change
| children: createRawSnippet(() => ({ render: () => 'Sparkly Text' })) | |
| children: createRawSnippet(() => ({ render: () => 'Sparkly Text' })), | |
| sparkleAmount: 8, | |
| sparkleRate: 250, | |
| sparkleVariance: 200, | |
| disabled: false, | |
| allowPausing: true, | |
| size: '1rem', | |
| animationLength: '900ms', | |
| color: '#FFC700', | |
| textShadowColor: 'none' |
migueldlr
reviewed
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the stray commit. Finally finished writing it and writing all the documentation for it. Hoping it's all good?